Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roi rectangle objects class #946

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Sep 6, 2022

Describe your changes
Update pcv.roi.rectangle to utilize the Objects class.

Type of update
Is this a:

  • New feature or feature enhancement
  • Update to documentation

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features ready to review update Updates an existing feature/method labels Sep 6, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Sep 6, 2022
@HaleySchuhl HaleySchuhl self-assigned this Sep 6, 2022
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Sep 6, 2022
@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 September 6, 2022 17:00
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #946 (ed30fd1) into release-4.0 (4a514f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0      #946   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              161       161           
  Lines             6840      6841    +1     
=============================================
+ Hits              6840      6841    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/roi/roi_methods.py 100.00% <100.00%> (ø)

Copy link
Member

@nfahlgren nfahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@nfahlgren nfahlgren merged commit 76cc3c7 into release-4.0 Sep 12, 2022
PlantCV4 automation moved this from Pull Requests to Done Sep 12, 2022
@nfahlgren nfahlgren deleted the update-roi-rectangle-Objects-class branch September 12, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review update Updates an existing feature/method
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants