Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report size marker objects class #955

Merged
merged 10 commits into from
Mar 22, 2023

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Sep 14, 2022

Describe your changes
Update pcv.report_size_marker input parameters to take new roi formatted Object.

Type of update
Is this a:

  • update

Associated issues
#945

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features work in progress Mark work in progress Objects class implementation labels Sep 14, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Sep 14, 2022
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Sep 14, 2022
@HaleySchuhl HaleySchuhl self-assigned this Sep 14, 2022
@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 September 14, 2022 17:45
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release-4.0@3129d85). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head eda1f1a differs from pull request most recent head d47b063. Consider uploading reports for the commit d47b063 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             release-4.0     #955   +/-   ##
==============================================
  Coverage               ?   99.98%           
==============================================
  Files                  ?      161           
  Lines                  ?     6849           
  Branches               ?        0           
==============================================
  Hits                   ?     6848           
  Misses                 ?        1           
  Partials               ?        0           
Flag Coverage Δ
unittests 99.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/report_size_marker_area.py 100.00% <100.00%> (ø)

@HaleySchuhl HaleySchuhl added ready to review and removed work in progress Mark work in progress labels Sep 27, 2022
@maliagehan maliagehan self-requested a review March 22, 2023 16:10
Copy link
Member

@maliagehan maliagehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you haley, I tested it!

@nfahlgren nfahlgren merged commit 9583e77 into release-4.0 Mar 22, 2023
PlantCV4 automation moved this from Pull Requests to Done Mar 22, 2023
@nfahlgren nfahlgren deleted the update-report_size_marker-Objects-class branch March 22, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants