Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hsi read data flexible hdr format #956

Merged
merged 45 commits into from
Apr 1, 2023
Merged

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Sep 15, 2022

Describe your changes
Update to /plantcv/hyperspectral/read_data.py with end goal of expanding flexibility with image formats. Moves .hdr file parsing and dictionary creation into a helper function.

Type of update
Is this a:

  • New feature or feature enhancement
  • Work in progress

Associated issues

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features work in progress Mark work in progress update Updates an existing feature/method labels Sep 15, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v3.14.2 milestone Sep 15, 2022
@HaleySchuhl HaleySchuhl self-assigned this Sep 15, 2022
@HaleySchuhl HaleySchuhl added this to In progress in PlantCV3 via automation Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #956 (a4edfcb) into main (9dbf801) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         6003      6028   +25     
=========================================
+ Hits          6003      6028   +25     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/hyperspectral/__init__.py 100.00% <100.00%> (ø)
plantcv/plantcv/hyperspectral/read_data.py 100.00% <100.00%> (ø)
plantcv/plantcv/readimage.py 100.00% <100.00%> (ø)

@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 September 23, 2022 18:35
@HaleySchuhl HaleySchuhl changed the base branch from release-4.0 to main September 26, 2022 18:53
@HaleySchuhl HaleySchuhl added ready to review cleanup Code quality updates and removed work in progress Mark work in progress labels Sep 30, 2022
@nfahlgren nfahlgren merged commit 582a438 into main Apr 1, 2023
5 checks passed
PlantCV3 automation moved this from In progress to Done Apr 1, 2023
@nfahlgren nfahlgren deleted the hsi-read_data-flexible-hdr-format branch April 1, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality updates enhancement Enhancements to existing features ready to review update Updates an existing feature/method
Projects
No open projects
PlantCV3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants