Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test cache dir #957

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Fix test cache dir #957

merged 3 commits into from
Sep 19, 2022

Conversation

nfahlgren
Copy link
Member

@nfahlgren nfahlgren commented Sep 19, 2022

Describe your changes
This PR sets the pcv.params.debug_outdir to the test cache tmp directory for the test test_segment_image_series to prevent test files from being saved to the source directory. Minor code format changes are also included

Type of update
Is this a: Bug fix

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

Prevents debug files from being saved to the source directory
@nfahlgren nfahlgren added the bugfix Bug fixes label Sep 19, 2022
@nfahlgren nfahlgren added this to the PlantCV v4.0 milestone Sep 19, 2022
@nfahlgren nfahlgren added this to Pull Requests in PlantCV4 via automation Sep 19, 2022
matplotlib 3.6 seems to break plotnine
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #957 (0929162) into release-4.0 (fe40c16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.0      #957   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              161       161           
  Lines             6859      6859           
=============================================
  Hits              6859      6859           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit b5a78e1 into release-4.0 Sep 19, 2022
PlantCV4 automation moved this from Pull Requests to Done Sep 19, 2022
@nfahlgren nfahlgren deleted the fix-test-cache-dir branch September 19, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants