Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release 4.0 #969

Merged
merged 11 commits into from
Oct 14, 2022
Merged

Update release 4.0 #969

merged 11 commits into from
Oct 14, 2022

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Oct 13, 2022

Describe your changes

Type of update
Is this a:

  • Bug fix
  • update

Associated issues
Reference associated issue numbers. Does this pull request close any issues?

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #969 (3627746) into release-4.0 (44e12ce) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-4.0      #969    +/-   ##
==============================================
  Coverage       100.00%   100.00%            
==============================================
  Files              161       147    -14     
  Lines             6857      6641   -216     
==============================================
- Hits              6857      6641   -216     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/hyperspectral/analyze_spectral.py 100.00% <100.00%> (ø)
plantcv/plantcv/morphology/__init__.py
plantcv/plantcv/photosynthesis/__init__.py
plantcv/plantcv/visualize/__init__.py
plantcv/utils/__init__.py
plantcv/parallel/__init__.py
plantcv/plantcv/hyperspectral/__init__.py
plantcv/plantcv/io/__init__.py
plantcv/plantcv/threshold/__init__.py
plantcv/plantcv/__init__.py
... and 5 more

@HaleySchuhl HaleySchuhl added ready to review update Updates an existing feature/method labels Oct 13, 2022
@nfahlgren nfahlgren merged commit d6ffe4e into release-4.0 Oct 14, 2022
@nfahlgren nfahlgren deleted the UPDATE-release-4.0 branch October 14, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to review update Updates an existing feature/method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants