-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compatibility for BIP data format of hsi images in read_image #972
Conversation
Well, the test fails because bip does not rise an error anymore. |
Should be good to go @HaleySchuhl |
Thanks @vektorious for opening this PR! I think @nfahlgren will need to add you as a collaborator for totally automated testing, but I don't think there's any additional tests needed to cover the new code which is always nice. We should be able to get you added to the project soon; thanks again for your contributions! |
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 149 129 -20
Lines 7758 5813 -1945
===========================================
- Hits 7758 5813 -1945
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bip -> bup 👍🏼😂
Sure! You are welcome 🙂 |
Thank you! |
Changes
Added the BIP (Bands Interleaved by Pixel) data format for reading hyperspectral images.
Type of update
Is this a:
Associated issues
Associated Issue: #203
Additional context
Compatibility for BIP data format was missing.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md