Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility for BIP data format of hsi images in read_image #972

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

vektorious
Copy link
Contributor

@vektorious vektorious commented Oct 25, 2022

Changes
Added the BIP (Bands Interleaved by Pixel) data format for reading hyperspectral images.

Type of update
Is this a:

  • Feature enhancement
  • Related update to documentation

Associated issues
Associated Issue: #203

Additional context
Compatibility for BIP data format was missing.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features new feature New feature ideas and solutions labels Oct 27, 2022
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Oct 27, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Oct 27, 2022
@vektorious
Copy link
Contributor Author

Well, the test fails because bip does not rise an error anymore.
I'll fix the test.

@vektorious vektorious closed this Oct 27, 2022
PlantCV4 automation moved this from Pull Requests to Done Oct 27, 2022
@vektorious vektorious reopened this Oct 27, 2022
PlantCV4 automation moved this from Done to Pull Requests Oct 27, 2022
@vektorious
Copy link
Contributor Author

Should be good to go @HaleySchuhl
Seems like I can't trigger the build tests myself.

@HaleySchuhl
Copy link
Contributor

Thanks @vektorious for opening this PR! I think @nfahlgren will need to add you as a collaborator for totally automated testing, but I don't think there's any additional tests needed to cover the new code which is always nice. We should be able to get you added to the project soon; thanks again for your contributions!

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #972 (031ada5) into main (c3b0578) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              main      #972     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          149       129     -20     
  Lines         7758      5813   -1945     
===========================================
- Hits          7758      5813   -1945     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/hyperspectral/read_data.py 100.00% <ø> (ø)
plantcv/__init__.py 100.00% <0.00%> (ø)
plantcv/plantcv/_debug.py 100.00% <0.00%> (ø)
plantcv/plantcv/classes.py 100.00% <0.00%> (ø)
plantcv/parallel/parsers.py 100.00% <0.00%> (ø)
plantcv/utils/converters.py 100.00% <0.00%> (ø)
plantcv/plantcv/plot_image.py 100.00% <0.00%> (ø)
plantcv/plantcv/print_image.py 100.00% <0.00%> (ø)
plantcv/plantcv/roi_objects.py 100.00% <0.00%> (ø)
plantcv/utils/sample_images.py 100.00% <0.00%> (ø)
... and 37 more

Copy link
Contributor

@HaleySchuhl HaleySchuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bip -> bup 👍🏼😂

@vektorious
Copy link
Contributor Author

Sure! You are welcome 🙂

@nfahlgren nfahlgren merged commit 7cc666e into danforthcenter:main Oct 27, 2022
PlantCV4 automation moved this from Pull Requests to Done Oct 27, 2022
@nfahlgren
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features new feature New feature ideas and solutions
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants