Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize Objects class in pcv.roi.from_binary_image #980

Merged
merged 6 commits into from
Mar 22, 2023

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Nov 9, 2022

Describe your changes
More implementation from #945

Docs, tests, and code updated to utilize Objects class

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features Objects class implementation labels Nov 9, 2022
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Nov 9, 2022
@HaleySchuhl HaleySchuhl self-assigned this Nov 9, 2022
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #980 (6cd80be) into release-4.0 (03829b2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-4.0     #980   +/-   ##
============================================
  Coverage        99.98%   99.98%           
============================================
  Files              161      161           
  Lines             6849     6850    +1     
============================================
+ Hits              6848     6849    +1     
  Misses               1        1           
Flag Coverage Δ
unittests 99.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/roi/roi_methods.py 100.00% <100.00%> (ø)

Copy link
Contributor

@JorgeGtz JorgeGtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nfahlgren nfahlgren merged commit 3129d85 into release-4.0 Mar 22, 2023
PlantCV4 automation moved this from Pull Requests to Done Mar 22, 2023
@nfahlgren nfahlgren deleted the from_binary_image-Objects-update branch March 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants