-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update roi circle objects class #993
Conversation
Codecov Report
@@ Coverage Diff @@
## release-4.0 #993 +/- ##
==============================================
Coverage ? 99.98%
==============================================
Files ? 161
Lines ? 6851
Branches ? 0
==============================================
Hits ? 6850
Misses ? 1
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
docs/roi_circle.md
Outdated
@@ -24,7 +24,7 @@ from plantcv import plantcv as pcv | |||
# or "plot" (Jupyter Notebooks or X11) | |||
pcv.params.debug = "print" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider changing these to "plot"
? I think that would be more beginner friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
Describe your changes
Updating
pcv.roi.circle
(andpcv.transform.create_color_card_mask
since it usespcv.roi.circle
within the code) to use Objects class logic throughoutType of update
Is this a:
Associated issues
#945
Additional context
Add any other context about the problem here.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md