Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roi circle objects class #993

Merged
merged 9 commits into from
Mar 22, 2023

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Jan 5, 2023

Describe your changes
Updating pcv.roi.circle (and pcv.transform.create_color_card_mask since it uses pcv.roi.circle within the code) to use Objects class logic throughout

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
#945

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl self-assigned this Jan 5, 2023
@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features work in progress Mark work in progress labels Jan 5, 2023
@HaleySchuhl HaleySchuhl added this to Pull Requests in PlantCV4 via automation Jan 5, 2023
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.0 milestone Jan 5, 2023
@HaleySchuhl HaleySchuhl changed the base branch from main to release-4.0 January 5, 2023 17:03
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-4.0@9583e77). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 42a8762 differs from pull request most recent head b9f0c53. Consider uploading reports for the commit b9f0c53 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             release-4.0     #993   +/-   ##
==============================================
  Coverage               ?   99.98%           
==============================================
  Files                  ?      161           
  Lines                  ?     6851           
  Branches               ?        0           
==============================================
  Hits                   ?     6850           
  Misses                 ?        1           
  Partials               ?        0           
Flag Coverage Δ
unittests 99.98% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plantcv/plantcv/roi/roi_methods.py 100.00% <100.00%> (ø)
plantcv/plantcv/transform/color_correction.py 100.00% <100.00%> (ø)

@@ -24,7 +24,7 @@ from plantcv import plantcv as pcv
# or "plot" (Jupyter Notebooks or X11)
pcv.params.debug = "print"
Copy link
Contributor

@JorgeGtz JorgeGtz Mar 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider changing these to "plot"? I think that would be more beginner friendly.

Copy link
Contributor

@JorgeGtz JorgeGtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@nfahlgren nfahlgren merged commit 912c400 into release-4.0 Mar 22, 2023
PlantCV4 automation moved this from Pull Requests to Done Mar 22, 2023
@nfahlgren nfahlgren deleted the Update-roi-circle-OBJECTS-class branch March 22, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
PlantCV4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants