Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改正远程暴露时的注释文字错误 #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xudachong
Copy link

原文:
//如果配置不是local则暴露为远程服务.(配置为local,则表示只暴露远程服务)
if (! Constants.SCOPE_LOCAL.toString().equalsIgnoreCase(scope) ){
错误点:只暴露远程服务应改为只暴露本地服务
dubbo的服务暴露,scope配置为none则不暴露,配置为remote为远程暴露,配置为local则为本地暴露
相信当当的开发者应该知道上述的原理,而注释错误应该只是复制时忘了修改。
注释是代码的旁白,对于代码的阅读者有很大的引导作用,而服务暴露又是dubbo的必看之处。
所以希望改正

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant