Skip to content

Commit

Permalink
Update to TSLint 4.4 (#113)
Browse files Browse the repository at this point in the history
A bugfix in TSLint 4.4 revealed a few instances of trailing whitespace
in comments. See palantir/tslint#2060.
  • Loading branch information
macklinu committed Jan 25, 2017
1 parent fb4a046 commit 18caf4c
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 18 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
"shx": "^0.2.1",
"ts-jest": "^18.0.1",
"ts-node": "^2.0.0",
"tslint": "^4.2.0",
"tslint": "^4.4.0",
"typescript": "^2.1.4"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion source/commands/danger-pr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (program.args.length === 0) {
console.error("Could not get a repo and a PR number from your URL, bad copy & paste?")
process.exitCode = 1
} else {
// TODO: Use custom `fetch` in GitHub that stores and uses local cache if PR is closed, these PRs
// TODO: Use custom `fetch` in GitHub that stores and uses local cache if PR is closed, these PRs
// shouldn't change often and there is a limit on API calls per hour.

if (validateDangerfileExists(dangerFile)) {
Expand Down
2 changes: 1 addition & 1 deletion source/commands/danger-run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {Executor} from "../runner/Executor"
const d = debug("danger:run")
declare const global: any

// TODO: if we get more options around the dangerfile, we should
// TODO: if we get more options around the dangerfile, we should
// support sharing `program` setup code with danger-pr.ts

program
Expand Down
4 changes: 2 additions & 2 deletions source/runner/DangerfileRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ export async function runDangerfileEnvironment(filename: Path, environment: Dang
* Passes in a dangerfile path, will remove any references to import/require `danger`
* then runs the internal closure with a "safe" version of the Dangerfile.
* Then it will clean itself up afterwards, and use the new version.
*
*
* Note: We check for equality to not trigger the jest watcher for tests.
*
* @param {string} filename the file path for the dangerfile
* @param {Function} closure code to run with a cleaned Dangerfile
* @returns {void}
* @returns {void}
*/
function ensureCleanDangerfile(filename: string, closure: Function) {
const originalContents = fs.readFileSync(filename).toString()
Expand Down
18 changes: 5 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3542,7 +3542,7 @@ spdx-license-ids@^1.0.2:
version "1.2.2"
resolved "https://registry.yarnpkg.com/spdx-license-ids/-/spdx-license-ids-1.2.2.tgz#c9df7a3424594ade6bd11900d596696dc06bac57"

sprintf-js@^1.0.3, sprintf-js@~1.0.2:
sprintf-js@~1.0.2:
version "1.0.3"
resolved "https://registry.yarnpkg.com/sprintf-js/-/sprintf-js-1.0.3.tgz#04e6926f662895354f3dd015203633b857297e2c"

Expand Down Expand Up @@ -3789,9 +3789,9 @@ tsconfig@^5.0.2:
strip-bom "^2.0.0"
strip-json-comments "^2.0.0"

tslint@^4.2.0:
version "4.2.0"
resolved "https://registry.yarnpkg.com/tslint/-/tslint-4.2.0.tgz#b9f5c5b871b784ab2f4809e704ade42d62f523ad"
tslint@^4.4.0:
version "4.4.0"
resolved "https://registry.yarnpkg.com/tslint/-/tslint-4.4.0.tgz#748d17bf8598dd044cca5771a03353ea422da29e"
dependencies:
babel-code-frame "^6.20.0"
colors "^1.1.2"
Expand All @@ -3800,7 +3800,6 @@ tslint@^4.2.0:
glob "^7.1.1"
optimist "~0.6.0"
resolve "^1.1.7"
underscore.string "^3.3.4"
update-notifier "^1.0.2"

tunnel-agent@~0.4.1:
Expand Down Expand Up @@ -3838,13 +3837,6 @@ uid-number@~0.0.6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/uid-number/-/uid-number-0.0.6.tgz#0ea10e8035e8eb5b8e4449f06da1c730663baa81"

underscore.string@^3.3.4:
version "3.3.4"
resolved "https://registry.yarnpkg.com/underscore.string/-/underscore.string-3.3.4.tgz#2c2a3f9f83e64762fdc45e6ceac65142864213db"
dependencies:
sprintf-js "^1.0.3"
util-deprecate "^1.0.2"

unzip-response@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/unzip-response/-/unzip-response-1.0.2.tgz#b984f0877fc0a89c2c773cc1ef7b5b232b5b06fe"
Expand Down Expand Up @@ -3872,7 +3864,7 @@ user-home@^1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/user-home/-/user-home-1.1.1.tgz#2b5be23a32b63a7c9deb8d0f28d485724a3df190"

util-deprecate@^1.0.2, util-deprecate@~1.0.1:
util-deprecate@~1.0.1:
version "1.0.2"
resolved "https://registry.yarnpkg.com/util-deprecate/-/util-deprecate-1.0.2.tgz#450d4dc9fa70de732762fbd2d4a28981419a0ccf"

Expand Down

0 comments on commit 18caf4c

Please sign in to comment.