Allow repository name parsing to have extra valid characters

danger · Oct 10, 2018 · 2b2f054 · 2b2f054
1 parent b478682
commit 2b2f054
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/source/platforms/_tests/_pull_request_parser.test.ts b/source/platforms/_tests/_pull_request_parser.test.ts
@@ -40,4 +40,13 @@ describe("parsing urls", () => {
       repo: "projects/PROJ/repos/super-repo",
     })
   })
+
+  it("handles bitbucket server PRs (overview) with dashes in name", () => {
+    expect(
+      pullRequestParser("http://localhost:7990/projects/PROJ/repos/super-strong.repo_name/pull-requests/1/overview")
+    ).toEqual({
+      pullRequestNumber: "1",
+      repo: "projects/PROJ/repos/super-strong.repo_name",
+    })
+  })
 })
diff --git a/source/platforms/pullRequestParser.ts b/source/platforms/pullRequestParser.ts
@@ -11,7 +11,7 @@ export function pullRequestParser(address: string): PullRequestParts | null {
 
   if (components && components.path) {
     // shape: http://localhost:7990/projects/PROJ/repos/repo/pull-requests/1/overview
-    const parts = components.path.match(/(projects\/\w+\/repos\/[\w-]+)\/pull-requests\/(\d+)/)
+    const parts = components.path.match(/(projects\/\w+\/repos\/[\w-_.]+)\/pull-requests\/(\d+)/)
     if (parts) {
       return {
         repo: parts[1],