Fixes inline commenting in GitLab

danger · Apr 9, 2019 · 76b7bb1 · 76b7bb1
1 parent a22c68b
commit 76b7bb1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/source/dsl/GitLabDSL.ts b/source/dsl/GitLabDSL.ts
@@ -185,9 +185,9 @@ export interface GitLabDiscussionTextPosition {
   start_sha: string
   head_sha: string
   new_path: string
-  new_line: string
+  new_line: number
   old_path: string
-  old_line: string | null
+  old_line: number | null
 }
 
 export interface GitLabInlineNote extends GitLabNote {

diff --git a/source/platforms/GitLab.ts b/source/platforms/GitLab.ts
@@ -158,7 +158,7 @@ class GitLab implements Platform {
       old_path: path,
       old_line: null,
       new_path: path,
-      new_line: `${line}`,
+      new_line: line,
     })
   }
 

diff --git a/source/platforms/gitlab/GitLabAPI.ts b/source/platforms/gitlab/GitLabAPI.ts
@@ -1,14 +1,14 @@
 import { RepoMetaData } from "../../dsl/BitBucketServerDSL"
 import { api as fetch } from "../../api/fetch"
 import {
+  GitLabDiscussionTextPosition,
+  GitLabInlineNote,
   GitLabMR,
-  GitLabMRChanges,
   GitLabMRChange,
+  GitLabMRChanges,
   GitLabMRCommit,
-  GitLabUserProfile,
-  GitLabInlineNote,
   GitLabNote,
-  GitLabDiscussionTextPosition,
+  GitLabUserProfile,
 } from "../../dsl/GitLabDSL"
 
 import { Gitlab } from "gitlab"
@@ -126,7 +126,7 @@ class GitLabAPI {
 
     try {
       const res = await api.create(this.repoMetadata.repoSlug, this.repoMetadata.pullRequestID, content, {
-        position,
+        position: position,
       })
 
       return res