Fix build status

danger · Feb 25, 2018 · c5cf5b3 · c5cf5b3
1 parent ca4b9ba
commit c5cf5b3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/source/danger.d.ts b/source/danger.d.ts
@@ -44,7 +44,7 @@ declare module "danger" {
    */
 
   interface BitBucketServerPRDSL {
-    id: string
+    id: number
     version: number
     title: string
     description: string

diff --git a/source/platforms/BitBucketServer.ts b/source/platforms/BitBucketServer.ts
@@ -34,7 +34,7 @@ export class BitBucketServer implements Platform {
 
   updateStatus = async (passed: boolean, message: string, url?: string): Promise<boolean> => {
     const pr = await this.api.getPullRequestInfo()
-    const { latestCommit } = pr.toRef
+    const { latestCommit } = pr.fromRef
     try {
       await this.api.postBuildStatus(latestCommit, {
         state: passed ? "SUCCESSFUL" : "FAILED",

diff --git a/source/platforms/bitbucket_server/BitBucketServerAPI.ts b/source/platforms/bitbucket_server/BitBucketServerAPI.ts
@@ -137,6 +137,7 @@ export class BitBucketServerAPI {
     }
   ) => {
     const res = await this.post(`rest/build-status/1.0/commits/${commitId}`, {}, payload)
+    throwIfNotOk(res)
     return await res.json()
   }
 

diff --git a/source/runner/templates/bitbucketServerTemplate.ts b/source/runner/templates/bitbucketServerTemplate.ts
@@ -46,7 +46,7 @@ export const dangerSignaturePostfix = `_Generated by 🚫 [dangerJS](http://gith
 export function template(dangerID: string, results: DangerResults): string {
   return `
 ${resultsSection("Fails", "🚫", results.fails)}
-${resultsSection("Warnings", "⚠", results.warnings)}
+${resultsSection("Warnings", "⚠️", results.warnings)}
 ${resultsSection("Messages", "📖", results.messages)}
 
 ---