Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Provide some messaging if you are not on pull_request for GitHUb Actions CI #1438

Closed
orta opened this issue Apr 18, 2024 · 0 comments · Fixed by #1439
Closed

[Feature] Provide some messaging if you are not on pull_request for GitHUb Actions CI #1438

orta opened this issue Apr 18, 2024 · 0 comments · Fixed by #1439
Labels

Comments

@orta
Copy link
Member

orta commented Apr 18, 2024

Describe the bug

name: CI
on: push
jobs:
  test:
    name: Lint, typecheck & test
    runs-on: ubuntu-latest

    steps:
      - name: Danger
        run: yarn danger ci --verbose
        env:
          DEBUG: danger:*
          DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Does not have danger.github.pr because it is not a PR run - however, because Danger can run on any GitHub workflow then things are going to be real surprising when it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant