Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn doesn't seem to add anything to pull requests #52

Closed
dblock opened this issue Dec 19, 2016 · 9 comments
Closed

Warn doesn't seem to add anything to pull requests #52

dblock opened this issue Dec 19, 2016 · 9 comments
Labels

Comments

@dblock
Copy link

dblock commented Dec 19, 2016

https://travis-ci.org/matt-kruse/alexa-app/builds/185211730

> alexa-app@2.3.4 danger /home/travis/build/matt-kruse/alexa-app
> danger
OK, looks good Travis CI on GitHub
Failed

https://github.com/matt-kruse/alexa-app/pull/91

@orta
Copy link
Member

orta commented Dec 19, 2016

Off-hand, it could be possible that it won't post if it's just a warning?

@dblock
Copy link
Author

dblock commented Dec 19, 2016

Uhm you tell me :) How do I post something? I thought I was importing warn that produces a Danger style warning.

@orta
Copy link
Member

orta commented Dec 19, 2016

hah - was just leaving a note for me when I get to this :D

You are correct - it should

@orta
Copy link
Member

orta commented Dec 21, 2016

I've reviewed the code, and double checked the tests - I'm not quite sure what this is yet - seen it on a bunch of PRs though

@macklinu
Copy link
Member

I'm wondering if it would be useful to have debug or verbose mode where we can log network requests/responses etc. to help with bug reports. Think that'd be useful here/as a separate issue?

@orta
Copy link
Member

orta commented Dec 21, 2016

Yeah, I think a verbose mode would be a great idea for this 👍

@dblock
Copy link
Author

dblock commented Jan 11, 2017

This is still a problem in 0.8.0, https://travis-ci.org/alexa-js/alexa-app-server/builds/190999804

@dblock
Copy link
Author

dblock commented Jan 11, 2017

Fail correctly fails the build, but still doesn't add anything to my PR.

https://travis-ci.org/alexa-js/alexa-app-server/builds/191001140

@dblock
Copy link
Author

dblock commented Jan 11, 2017

The problem here was that the bot account got flagged, so the messages simply didn't appear.

@dblock dblock closed this as completed Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants