New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: danger.git.modified_files.includes is not a function #95

Closed

dblock opened this issue Jan 11, 2017 · 4 comments

dblock commented Jan 11, 2017 •

edited

Danger 0.8.0. What am I missing?

https://travis-ci.org/matt-kruse/alexa-app-server/builds/190989229

Member

orta commented Jan 11, 2017

I can't see the build but includes was added in node 5/6 I think, so 4 and below fail?

Author

dblock commented Jan 11, 2017

This was with 5.11, correct link https://travis-ci.org/alexa-js/alexa-app-server/builds/190989229, sorry about that.

Member

kwonoj commented Jan 12, 2017

If you're using array.includes and node is 5.11, it's hidden behind harmony flag. http://node.green/#Array-prototype-includes

Member

macklinu commented Jan 19, 2017

I'm going to mark this as resolved, thanks for that info @kwonoj.

macklinu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment