Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript build fails when using danger for a plugin #995

Closed
rohit-gohri opened this issue Feb 15, 2020 · 0 comments · Fixed by #996
Closed

Typescript build fails when using danger for a plugin #995

rohit-gohri opened this issue Feb 15, 2020 · 0 comments · Fixed by #996
Assignees
Labels

Comments

@rohit-gohri
Copy link
Member

The build fails with this error:

node_modules/danger/distribution/dsl/GitHubDSL.d.ts:24:10 - error TS2709: Cannot use namespace 'GitHub' as a type.

24     api: GitHub;
            ~~~~~~


Found 1 error.

The error appears with @octokit/rest v16.43.1 but not before that.

From what I could gather the distribution template in

import * as GitHub from "@octokit/rest"
didn't get updated when PR #983 was done.

Also we should probably update the version in package.json to ^16.43.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant