Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #110

Merged
merged 6 commits into from
Nov 18, 2018
Merged

Suggestions #110

merged 6 commits into from
Nov 18, 2018

Conversation

f-meloni
Copy link
Member

@f-meloni f-meloni commented Nov 17, 2018

This is just until it doesn't get implement on danger-js

@@ -206,6 +218,11 @@ public func markdown(message: String, file: String, line: Int) {
DangerRunner.shared.dsl.markdown(message: message, file: file, line: line)
}

/// Adds an inline suggestion to the Danger report
public func suggestion(code: String, file: String, line: Int) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public func suggestion(code: String, file: String, line: Int) {
Test Suggestion

@orta orta self-assigned this Nov 17, 2018
@orta
Copy link
Member

orta commented Nov 18, 2018

Cool, yeah, looks good 👍

@orta orta merged commit ad2be9e into master Nov 18, 2018
@HeEAaD HeEAaD deleted the suggestions branch January 29, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants