SPM danger #174
Merged
SPM danger #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a temporary message taken from Yams to check if was correctly resolving the dependency |
DangerCI
reviewed
Jan 25, 2019
Sources/RunnerLib/SPMDanger.swift
Outdated
| public init?(packagePath: String = "Package.swift") { | ||
| let packageContent = (try? String(contentsOfFile: packagePath)) ?? "" | ||
|
|
||
| let regex = try? NSRegularExpression(pattern: "\\.library\\(name:[\\ ]?\"(\(SPMDanger.dangerDepsPrefix)[A-Za-z]*)", options: .allowCommentsAndWhitespace) |
There was a problem hiding this comment.
⚠️ Line should be 120 characters or less: currently 123 characters (line_length)
|
merge on green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible solution for #139
At the moment the two solutions coexist.
It requires both to define a target dependant from
Danger+ dependencies and a library calledThe name of the target is not relevant.