Github API Client #95
Conversation
Generated by 🚫 dangerJS |
Dangerfile.swift
Outdated
| group.leave() | ||
| } | ||
|
|
||
| group.wait() |
There was a problem hiding this comment.
cool, that worked, do we need the dispatch group? It should wait because danger waits till the end of the process
| config = TokenConfiguration(settings.github.accessToken, url: baseURL) | ||
| } else { | ||
| config = TokenConfiguration(settings.github.accessToken) | ||
| } |
There was a problem hiding this comment.
Cool, yep, this is what I expected 👍
| @@ -28,7 +29,8 @@ public struct GitHub: Decodable, Equatable { | |||
| public let reviews: [GitHubReview] | |||
|
|
|||
| public let requestedReviewers: GitHubRequestedReviewers | |||
|
|
|||
|
|
|||
| internal(set) public var api: Octokit! | |||
There was a problem hiding this comment.
internal? ( maybe I don't get how access rights work here)
There was a problem hiding this comment.
Just the set is internal (the api is set from DangerDSL, then it can not be private(set))
| "gists_url": "https://api.github.com/users/ashfurrow/gists{/gist_id}", | ||
| "starred_url": "https://api.github.com/users/ashfurrow/starred{/owner}{/repo}", | ||
| "subscriptions_url": "https://api.github.com/users/ashfurrow/subscriptions", | ||
|
|
There was a problem hiding this comment.
^ - this might have got revoked (check your emails) - unless it is one of mine?
There was a problem hiding this comment.
Is the one on the fixtures, but anyway is just to test it parses it correctly, then shouldn't matter
|
Looks good - want to add a changelog entry then you can merge 👍 |
This should solve #17