Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to the DSL that outputs all the known DSL attributes + their values #41

Closed
orta opened this issue Jan 30, 2016 · 2 comments

Comments

@orta
Copy link
Member

orta commented Jan 30, 2016

Before I've done something like this in the Dangerfile:

message "Insertions: #{insertions}"
message "Added: #{files_added}"
message "LOC: #{lines_of_code}"
message "Mod: #{files_modified}"

Which isn't great. Instead I should be able to add something like message_all_attributes or something. It would show all of the information in a nice table.

@orta
Copy link
Member Author

orta commented Feb 5, 2016

Aha!

These details can be added to the Danger message, we can hide them inside a HTML attribute that is not stripped ( similar to what we do to detect if it's come from Danger ) aweeeesome

@orta
Copy link
Member Author

orta commented Feb 8, 2016

#40 and #44 cover this - the commit sha is in the message and --verbose gives you all the info

@orta orta closed this as completed Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant