Migrate from moshi to kotlinx serialization #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-meloni
reviewed
Nov 15, 2020
| val repositoryId: Int, | ||
| val issues: Array<String>? | ||
| val repositoryId: Int, | ||
| val issues: Array<String>? = null |
There was a problem hiding this comment.
Given we can give a default value, can we remove the optionality and put an empty array in case is not present?
So the user has less things to worry about, this can be an empty array or an array of issues, currently can also be null.
We would remove a state with no changes for the user
Comment on lines
36
to
39
| @SerialName("allow_collaboration") | ||
| val allowCollaboration: Boolean?, | ||
| @Json(name="allow_maintainer_to_push") | ||
| @SerialName("allow_maintainer_to_push") | ||
| val allowMaintainerToPush: Boolean?, |
There was a problem hiding this comment.
I suppose we could default those to false if not present and remove the optional
f-meloni
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.