Merged by Peril

Read standard error when the shell executor fails
danger · Oct 23, 2019 · 87f0c8b · 87f0c8b
2 parents c5c8473 + 86b9703
commit 87f0c8b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,7 +13,8 @@
 
 ## Master
 
-- Add --version support [@f-meloni][] - [#278](https://github.com/danger/swift/pull/287)
+- Read standard error when the shell executor fails [@f-meloni][] - [#288](https://github.com/danger/swift/pull/288)
+- Add --version support [@f-meloni][] - [#287](https://github.com/danger/swift/pull/287)
 
 ## 2.0.6
 

diff --git a/Sources/DangerShellExecutor/ShellExecutor.swift b/Sources/DangerShellExecutor/ShellExecutor.swift
@@ -95,7 +95,7 @@ public struct ShellExecutor: ShellExecuting {
         }
 
         // OK, so it failed, raise a new error with all the useful metadata
-        let stderrData = stdout.fileHandleForReading.readDataToEndOfFile()
+        let stderrData = stderr.fileHandleForReading.readDataToEndOfFile()
         let stderrString = String(data: stderrData, encoding: .utf8)!
 
         throw SpawnError.commandFailed(command: command,