Merge pull request #596 from pouyayarandi/prevent-empty-swiftlint-res…

…ponse-from-failure
danger · Nov 6, 2023 · f76cd15 · f76cd15
2 parents a779c91 + 9d0b669
commit f76cd15
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@
 
 ## Master
 
+- Prevent empty SwiftLint violation response from failure [@pouyayarandi][] - [#596](https://github.com/danger/swift/pull/596)
+
 ## 3.17.1
 
 - Use http tap url on update homebrew script [@f-meloni][]

diff --git a/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift b/Sources/Danger/Plugins/SwiftLint/SwiftLint.swift
@@ -307,6 +307,9 @@ extension SwiftLint {
     }
 
     private static func makeViolations(from response: String, failAction: (String) -> Void) -> [SwiftLintViolation] {
+        guard !response.isEmpty else {
+            return []
+        }
         let decoder = JSONDecoder()
         do {
             let violations = try decoder.decode([SwiftLintViolation].self, from: Data(response.utf8))