Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab rRest api doesn't accept Project name anymore. #304

Open
farabi opened this issue Dec 19, 2019 · 5 comments
Open

Gitlab rRest api doesn't accept Project name anymore. #304

farabi opened this issue Dec 19, 2019 · 5 comments

Comments

@farabi
Copy link

farabi commented Dec 19, 2019

Hello.

Danger is trying to call the Gitlab rest api using the project name. while gitlab now only accepts the project ID as you can see in the documentation.

Here is the error, i get.

+ danger-swift ci
Error:  { HTTPError: Not Found
    at fn (/snapshot/danger-js/node_modules/ky/umd.js:242:12)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  name: 'HTTPError',
  response:
   Response {
     size: 0,
     timeout: 0,
     [Symbol(Body internals)]: { body: [PassThrough], disturbed: true, error: null },
     [Symbol(Response internals)]:
      { url:
         'https://gitlab.xxxx.com/api/v4/projects/project%2Fname/merge_requests/15/changes',
        status: 404,
        statusText: 'Not Found',
        headers: [Headers] } },
  description: '404 Project Not Found' }
@f-meloni
Copy link
Member

This could be a danger-js problem, which version of danger-js are you using?

@farabi
Copy link
Author

farabi commented Dec 19, 2019

@f-meloni Yes i confirm it's in Danger-js side.
I'm using the last version : 9.2.9.

@nesterenkodm
Copy link

same

@nesterenkodm
Copy link

relates to danger/danger-js#969

@lazy-var
Copy link

In addition to @farabi's apache configuration suggestion (danger/danger-js#969 (comment)) related with rest calls and encoded slashes, I needed NoDecode and nocanon parameters:

<VirtualHost *:port>
  AllowEncodedSlashes NoDecode

  <Location /example/>
    ProxyPass http://anotherserver:8080/example nocanon
  </Location>
</VirtualHost>

as explained here: https://stackoverflow.com/a/9933890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants