-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab rRest api doesn't accept Project name anymore #969
Comments
same |
Cool, makes sense - someone want to take a look at a fix? |
@orta |
@orta |
I believe it's this command Line 69 in dab0e63
|
that could not work given #958 :( |
Actually gitlab does accept project name, the issue is coming from apache configuration where local gitlab is hosted. The solution i did in my fork is to add a env variable "DANGER_GITLAB_PROJECT_ID". and if it's not defined then we use the project name. Lot of tools are using the same approach with the project id. If its ok for you, i add a pull request about that. otherwise , we close the ticket and i will keep using my fork. farabi/tap/danger-swift |
Seems like a good PR to me 👍 |
In addition to @farabi apache configuration suggestion, I needed NoDecode and nocanon parameters:
as explained here: https://stackoverflow.com/a/9933890 |
Edit: Turns out I was observing a different API URL construction issue... #1028 |
The intention is right to support project number ID, but Gitlab does support |
Hello.
Danger is trying to call the Gitlab rest api using the project name. while gitlab now only accepts the project ID as you can see in the documentation.
Here is the error, i get.
Error: { HTTPError: Not Found
at fn (/snapshot/danger-js/node_modules/ky/umd.js:242:12)
at process._tickCallback (internal/process/next_tick.js:68:7)
name: 'HTTPError',
response:
Response {
size: 0,
timeout: 0,
[Symbol(Body internals)]: { body: [PassThrough], disturbed: true, error: null },
[Symbol(Response internals)]:
{ url:
'https://gitlab.xxxx.com/api/v4/projects/project%2Fname/merge_requests/15/changes',
status: 404,
statusText: 'Not Found',
headers: [Headers] } },
description: '404 Project Not Found' }
The text was updated successfully, but these errors were encountered: