New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerfile evaluation is single threaded #99

Open
orta opened this Issue Nov 12, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@orta
Copy link
Member

orta commented Nov 12, 2018

Right now it looks like evaluation of a DangerFile is basically single threaded, meaning if you want to do anything with the network you have to have dispatch locks. This is likely because we're not executing the app, but running the swift compiler int an faux-eval mode.

This might not work in the long run, and we might need to switch out to actually compiling using swift-pm and then executing that binary which handles the eval runtime.

@orta

This comment has been minimized.

Copy link
Member

orta commented Dec 29, 2018

One current solution we have is to move the GitHub API to be synchronous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment