Import correctly the files when one of the files contains an emoji #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DangerCI
reviewed
Feb 19, 2019
| @@ -10,7 +10,7 @@ public final class DangerFileGenerator { | |||
|
|
|||
| importsRegex.enumerateMatches(in: content, options: [], range: NSRange(location: 0, length: content.count), using: { result, _, _ in | |||
There was a problem hiding this comment.
⚠️ Line should be 120 characters or less: currently 140 characters (line_length)
Generated by 🚫 Danger Swift against 05e4bb0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift tries to simplify the string.count by returning 1 for an emoji even if that is actually created with more than one
char.That means that we can not use count to adjust the range if there are emoticons in the string