Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SwiftLint plugin to use environment property on Process #207

Merged
merged 13 commits into from Mar 8, 2019
Merged

Update SwiftLint plugin to use environment property on Process #207

merged 13 commits into from Mar 8, 2019

Commits on Mar 7, 2019

  1. Update SwiftLint plugin to use environment 

    This was failing when the system shell is fish. Using the `environment` property on `Process` makes this shell-agnostic
    @JosephDuffy
    JosephDuffy committed Mar 7, 2019
    Copy the full SHA
    379ad33 View commit details
    Browse the repository at this point in the history

  2. Remove extra quotes around SwiftLint input files

    @JosephDuffy
    JosephDuffy committed Mar 7, 2019
    Copy the full SHA
    a46b394 View commit details
    Browse the repository at this point in the history

  3. Add fix for SwiftLint with fish to changelog

    @JosephDuffy
    JosephDuffy committed Mar 7, 2019
    Copy the full SHA
    651b13b View commit details
    Browse the repository at this point in the history

  4. Fix SwiftLint warnings 

    Maybe these were causing the linux builds to fail on CI? The reason isn’t obvious to me
    @JosephDuffy
    JosephDuffy committed Mar 7, 2019
    Copy the full SHA
    adc5c50 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Update print statement to aid debugging

    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    a287a9d View commit details
    Browse the repository at this point in the history

  2. Remove leading whitespace 

    This was done during the pre-commit hook but didn’t seem to be committed
    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    5a002a4 View commit details
    Browse the repository at this point in the history

  3. Add further debugging for Linux CI

    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    a46fe99 View commit details
    Browse the repository at this point in the history

  4. Merge environmentVariables with process variables

    @f-meloni
    f-meloni committed Mar 8, 2019
    Copy the full SHA
    3d795fd View commit details
    Browse the repository at this point in the history

  5. Revert Travis Linux debugging changes

    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    4342dcd View commit details
    Browse the repository at this point in the history

  6. Remove swiftlint:disable comment

    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    0456c44 View commit details
    Browse the repository at this point in the history

  7. Add comment to Fake.swift 

    This file is in a cycle of changes, I think thanks to SwiftLint
It seems to want to end with a new line, but also not start with whitespace. This comment both explains the file and fixes the SwiftLint issue
    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    d3759d7 View commit details
    Browse the repository at this point in the history

  8. Refactor logic for created task to function 

    `print` statement was also removed. This may we re-added in response to https://github.com/danger/swift/pull/207/files#r263776454
    @JosephDuffy
    JosephDuffy committed Mar 8, 2019
    Copy the full SHA
    228644c View commit details
    Browse the repository at this point in the history

  9. Swiftlint fix

    @f-meloni
    f-meloni committed Mar 8, 2019
    Copy the full SHA
    ebb5189 View commit details
    Browse the repository at this point in the history