Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not needed force unwrap #234

Merged
merged 3 commits into from
May 18, 2019
Merged

Remove not needed force unwrap #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
563cf2f
Remove not needed force unwrap
f-meloni May 18, 2019
23ee90c
Merge branch 'master' of github.com:danger/swift into remove_force_un…
f-meloni May 18, 2019
16d6697
Update CHANGELOG
f-meloni May 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

## Master

- Remove not needed force unwrap [@f-meloni][] - [#234](https://github.com/danger/swift/pull/234)
- Remove not needed coding keys [@f-meloni][] - [#233](https://github.com/danger/swift/pull/233)
- Re use the same executor on the runner [@f-meloni][] - [#230](https://github.com/danger/swift/pull/230)

Expand Down
4 changes: 2 additions & 2 deletions Sources/Danger/DangerUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ public struct DangerUtils {
public func readFile(_ file: File) -> String {
// Allows tests to map out their filesystem
// via a dictionary
if fileMap[file] != nil {
return fileMap[file]!
if let fileContent = fileMap[file] {
return fileContent
}

// Otherwise grab it from the FS
Expand Down