Fixing GitLabDSL parsing #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-meloni
reviewed
Oct 6, 2019
|
Done 👍 |
|
BTW, I could add check for |
|
@fortmarek that check already exist, I actually wondered why it didn't post here, and it came out that the Danger user need to verify its email in order to post https://travis-ci.org/danger/swift/jobs/593633791#L593 |
f-meloni
approved these changes
Oct 6, 2019
|
Huh, interesting, good to know, thanks for the merge! |
|
No problem! The change is not released on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding GitLab support, we stumbled upon some issues when certain keys were missing or did not correspond 1:1, so these are the fixes we applied to get it working.
Also, fixes: #279