Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use enum as namespace #296

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Use enum as namespace #296

merged 3 commits into from
Nov 27, 2019

Conversation

f-meloni
Copy link
Member

Given those structs/classes only have static function, they should be enum, that makes impossible initialise them.
They basically becomes simple namespaces

@danger-public
Copy link

danger-public commented Nov 26, 2019 •
edited
Loading

Warnings
⚠️

Sources/RunnerLib/Runtime.swift#L38 - TODOs should be resolved (Support running from a fork?). (todo)

Generated by 🚫 Danger Swift against b16ec40

sunshinejr
sunshinejr approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@sunshinejr sunshinejr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@f-meloni f-meloni merged commit 0c6c2b9 into master Nov 27, 2019
@f-meloni f-meloni deleted the enum_as_namespace branch November 27, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunshinejr sunshinejr sunshinejr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f-meloni @danger-public @sunshinejr