Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub draft support #341

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Add GitHub draft support #341

merged 1 commit into from
Apr 17, 2020

Conversation

captainbarbosa
Copy link
Contributor

Fixes #328

Adds support for determining if a pull request is in a draft state, mirroring GitHub's boolean response.

@captainbarbosa
Copy link
Contributor Author

captainbarbosa commented Apr 16, 2020 •
edited
Loading

@f-meloni 👋 Hey there, sorry for the noise from @danger-public. I'm trying to PR from a branch I made on a fork but all the CI checks are failing with the following: The command "danger-swift ci" exited with 1. - is there something I need to do on my fork to fix this?

@captainbarbosa
Copy link
Contributor Author

Ah okay, it seems to be failing because its running into a bunch of linting errors on CustomGitHubDSL.swift. I only added the draft property here, so I'm not sure why SwiftLint is suddenly picking up all of the violations for that file. I noticed DangerDSLGitHub.swift disabled some SwiftLint rules, so I went ahead did the same thing for CustomGitHubDSL.swift in 1402e0a.

f-meloni
f-meloni approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

Tests/DangerTests/GitHubTests.swift Outdated Show resolved Hide resolved
@f-meloni
Copy link
Member

Merge on green

@peril-staging peril-staging bot merged commit c8c6fc3 into danger:master Apr 17, 2020
@captainbarbosa captainbarbosa deleted the nb/add-github-drafts branch April 17, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
Merge On Green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support GitHub draft state
2 participants
@captainbarbosa @f-meloni