Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Link Relations for GitHub PR #368

Merged
merged 4 commits into from
Sep 20, 2020
Merged

Add Link Relations for GitHub PR #368

merged 4 commits into from
Sep 20, 2020

Conversation

417-72KI
Copy link
Member

@417-72KI 417-72KI commented Sep 8, 2020

The Pull Request API on GitHub has _links key, here is a doc.
https://docs.github.com/en/rest/reference/pulls#link-relations

This PR may resolve #364

f-meloni
f-meloni approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the PR it still work in progress, but the work looks really good to me!
Thank you for the PR :)

@417-72KI 417-72KI changed the title [WIP] Add Link Relations for GitHub PR Add Link Relations for GitHub PR Sep 18, 2020
@417-72KI 417-72KI marked this pull request as ready for review September 18, 2020 01:54
@417-72KI
Copy link
Member Author

@f-meloni
Thank you for reviewing!
May I merge this?

@f-meloni
Copy link
Member

Sure :)

@f-meloni f-meloni merged commit ae7eb60 into danger:master Sep 20, 2020
@417-72KI 417-72KI deleted the github-pr-link-relations branch September 20, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Github PR linked issues
2 participants
@417-72KI @f-meloni