make SwiftLintViolation properties public

[feighter09]

In our project, we use swiftlint to flag todos as warnings in addition to style warnings. For todos, we have a limit of ~10 before we want to block the build, while we don't want any style / compiler warnings allowed, so I'd like to write a danger rule like so:

let violations = SwiftLint.lint(.all(directory: nil))
let todosLimit = 10

let todos = violations.filter { $0.ruleID == "todo_rule" }
let warnings = violations.count - todos.count

if warnings.count > 0 {
    fail("Warning count exceeds \(warningsLimit) warnings")
}
if todos.count > todosLimit {
    fail("todo count exceeds \(todosLimit) todos")
}

but currently cannot as ruleID is marked internal

[417-72KI]

I think this also can be public 🤔

[f-meloni]

I think this is mainly for the PR message, so given they are automatically posted I think this can stay internal

[f-meloni]

Thank you for the PR, I think this is a reasonable change, we are returning the violations so makes sense to make them usable

[f-meloni]

I think this is mainly for the PR message, so given they are automatically posted I think this can stay internal