Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Danger work well with --package-path #406

Merged
merged 3 commits into from
Feb 9, 2021
Merged

Make Danger work well with --package-path #406

merged 3 commits into from
Feb 9, 2021

Conversation

f-meloni
Copy link
Member

@f-meloni f-meloni commented Feb 4, 2021

No description provided.

@danger-public
Copy link

danger-public commented Feb 4, 2021 •
edited
Loading

Warnings
⚠️

Sources/Runner/Commands/RunDangerJS.swift#L5 - Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)
⚠️

Sources/RunnerLib/Runtime.swift#L38 - TODOs should be resolved (Support running from a fork?). (todo)

Generated by 🚫 Danger Swift against 21a365e

@f-meloni f-meloni marked this pull request as ready for review February 9, 2021 00:57
@f-meloni f-meloni merged commit c71f0e9 into master Feb 9, 2021
@JosephDuffy JosephDuffy mentioned this pull request Feb 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f-meloni @danger-public