-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suffix temporary directory with unique path #530
Suffix temporary directory with unique path #530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you please update the CHANGELOG file as well? :)
Of course! Looks like I've broken all of the pipelines though :( |
Fixes #529 Reusing the temporary directory can cause issues with concurrent instances of Danger. By appending a unique identifier we can prevent race conditions when running Danger from concurrent processes.
All set for review now @f-meloni, sorry for the CI spam! When the runner is run, it creates a new temporary directory with a unique ID, for example:
The temporary files are then created within this folder. Upon completion (either success or failure), then the unique folder is cleaned up leaving only the parent folder:
One thing I'm unsure of though, is the |
Do I need to do anything else to get this merged in? |
No, I thought I merged it already, sorry |
Thanks so much! |
Fixes #529
Reusing the temporary directory can cause issues with concurrent instances of Danger. By appending a unique identifier we can prevent race conditions when running Danger from concurrent processes.