Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monterey support #532

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Monterey support #532

merged 8 commits into from
Oct 26, 2022

Conversation

417-72KI
Copy link
Member

@417-72KI 417-72KI commented Aug 29, 2022

  • Switch mac-os runner on CI
  • Add testing on Swift 5.6, 5.7

ref:
https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md

@417-72KI
Copy link
Member Author

NOTE:
Since Swift 5.6 Package.resolved's version has been updated to 2 (ref), and causes

ERROR: keyNotFound(CodingKeys(stringValue: "object", intValue: nil), Swift.DecodingError.Context(codingPath: [], debugDescription: "No value associated with key CodingKeys(stringValue: \"object\", intValue: nil) (\"object\").", underlyingError: nil))

TODO: fix PackageDataProvider.resolvePinnedPackages(generatedFolder:) to apply Package.resolved version 2.

@417-72KI 417-72KI marked this pull request as ready for review October 17, 2022 01:53
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! thank you :)

@417-72KI 417-72KI merged commit 455f7ed into danger:master Oct 26, 2022
@417-72KI 417-72KI deleted the monterey-support branch October 26, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants