feat: Update SwiftLint used by danger-swift-with-swiftlint to 0.49.1 #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure whether the CHANGELOG.md needs to be updated. Do let me know if that's required. Thanks. |
|
It would be definitely nice! Thank you :) |
|
Sure. Updated. |
417-72KI
reviewed
Sep 23, 2022
| @@ -530,3 +531,6 @@ This release also includes: | |||
| [@lunij]: https://github.com/lunij | |||
| [@majd]: https://github.com/majd | |||
| [@pouyayarandi]: https://github.com/pouyayarandi | |||
| [@Kiran-B]: https://github.com/Kiran-B | |||
| [SwiftLint]: https://github.com/realm/SwiftLint | |||
There was a problem hiding this comment.
It would be nice to leave a line blank, that make user's link block and others🤔
|
Hey @Kiran-B sorry, I had to temporarily revert this, because at the moment is not working, and so the build for the release failed :( https://github.com/danger/swift/actions/runs/3249467853/jobs/5331906227#step:8:128 |
|
Sorry, my bad. Missed updating Docker Container. Need to replace with or (to future proof) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
SwiftLintfrom v0.46.1 -> 0.49.1 in the Dockerfile.Details about whats new in SwiftLint is available here:
https://github.com/realm/SwiftLint/releases