Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swift docker version #542

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Bump swift docker version #542

merged 2 commits into from
Oct 26, 2022

Conversation

mxsc
Copy link
Contributor

@mxsc mxsc commented Oct 24, 2022

We got some weird issue because of incompatible Package.resolved files. Mostly because or toolchain is on swift 5.7 and the docker image we use in the GitHub actions is on 5.3.3.

Not sure what the procedure is around here with bumping to the latest swift build tools. So feel free to close if this is too early or I should create an issue first.

Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Can you please update the changelog too?

@mxsc
Copy link
Contributor Author

mxsc commented Oct 26, 2022

like this @f-meloni ? 😅

@f-meloni
Copy link
Member

Yes!
PS. you don't need to add the version, that is added by the automation, but I will remove it later don't worry :)

@f-meloni f-meloni merged commit fe2069c into danger:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants