Fix for issue #1587 #1588
Merged
Fix for issue #1587 #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like a workaround rather than a fix to me |
|
Show us the right way please. |
|
A workaround is better than nothing, thank you |
|
workaround only fixes a single day while breaking the prior day, so doesn't actually fix this
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized this 'cause 15 oct 2017 was the first day of daylight saving time in Brazil and my app fails there.
I found the problem is because an issue with endOf('day') moment function (moment/moment#3132), that still open there.
So I figured out how to deal with it by myself work around with the logic in datarangepicker.js.