Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current install instructions fail #97

Closed
KramNamez opened this issue Nov 30, 2022 · 2 comments
Closed

Current install instructions fail #97

KramNamez opened this issue Nov 30, 2022 · 2 comments

Comments

@KramNamez
Copy link

KramNamez commented Nov 30, 2022

If I run make full, it asks me to Input a git ref (commit hash, branch name, tag name, 'master'): and if I then give it 'master' as an input, it fails with the following error:

Hunk #1 succeeded at 58 (offset 1 line).
Checking patch libs/angular/src/components/register.component.ts...
error: while searching for:
  }

  async submit(showToast = true) {
    let email = this.formGroup.get("email")?.value;
    email = email.trim().toLowerCase();
    let name = this.formGroup.get("name")?.value;

error: patch failed: libs/angular/src/components/register.component.ts:96
Applied patch apps/web/src/404.html cleanly.
Applied patch apps/web/src/app/app.component.ts cleanly.
Applied patch apps/web/src/app/core/init.service.ts cleanly.
Applied patch apps/web/src/app/core/web-platform-utils.service.ts cleanly.
Applied patch apps/web/src/app/layouts/footer.component.html cleanly.
Applied patch apps/web/src/app/layouts/frontend-layout.component.html cleanly.
Applied patch apps/web/src/app/layouts/navbar.component.html cleanly.
Applied patch apps/web/src/app/organizations/create/organization-information.component.html cleanly.
Applied patch apps/web/src/app/organizations/settings/account.component.html cleanly.
Applied patch apps/web/src/app/organizations/vault/vault.component.ts cleanly.
Applied patch apps/web/src/app/send/access.component.html cleanly.
Applied patch apps/web/src/app/settings/settings.component.ts cleanly.
Applied patch apps/web/src/app/vault/vault.component.ts cleanly.
Applied patch apps/web/src/scss/styles.scss cleanly.
Applying patch libs/angular/src/components/register.component.ts with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
FAILED: line 18, exit code 1. Press any key to exit... make: *** [Makefile:22: patch-web-vault] Error 1
@BlackDex
Copy link
Collaborator

The current patch isn't valid for the current master.
These patches are linked to the specific version numbers, since Bitwarden changes there code, we need to change our patches.

Also, the latest patch we have is also not working for v2022.11.x, we are in the process of creating a new patch, until that time fix the patch your self, or use an older version.

@BlackDex BlackDex closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2022
@KramNamez
Copy link
Author

KramNamez commented Dec 1, 2022

Okay, so the install instructions are simply incomplete? Because there's nothing in there about having to input a git ref, and even less so about having to pick a specific one.

I think I understand now that I would have needed to give a tag name, like v2022.10.0 or similar. I'll see if I can add a bit about that into the install instructions.

I don't mind if it's temporarily broken, but the instructions would never work as-is, because that's missing, as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants