don't stash the node_modules folder #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually never use the host provide tools, and always use the docker commands. That way my host keeps clean and those files never appear. Not sure if this will work fully. I'll need to check. |
currently, if you built the web-vault the `node_modules` folder is stashed which takes a long time. since this is an ignored folder and we use `npm ci` to build the web-vault we don't really need to stash it. `npm ci` will always start with a clean build anyway. see https://docs.npmjs.com/cli/v8/commands/npm-ci
stefan0xC
force-pushed
the
dont-stash-ignored
branch
from
c2954c3
to
a21f082
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I've made a separate #95 to keep the discussion on topic. |
BlackDex
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why
make checkoutalways takes so long and it's because we are usinggit stash --allwhich stashes also ignored files, i.d. thenode_modulesfolder, too. Not sure if this is necessary, since we usenpm cito build the web-vault so we don't really need to stash it, because it will always start with a clean build anyway.