-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not having an option to disable the websocket notification #3975
Comments
That has no use. The clients will still try to connect. So why disable it at all? If you want to do that, just block it in the reverse proxy. |
Isn't there a way to tell the client there's no websocket support? I have already tried to block the request in the reverse proxy and it worked, but I think maybe an option could be better. I am deploying vaultwarden to a serverless platform, and it works well until the v1.29.0 update. |
@lyc8503 how did you block the |
It seems that deploying to serverless platforms like aliyun is not officially supported. So I use a little hack: I just bound the |
As maintainers are not interested in this feature, closing this issue for now. Workaround: block requests to |
Subject of the issue
After updating to v1.29.0, websockets are enabled by default on the HTTP port. But I'd like to disable that.
Steps to reproduce
Just run vaultwarden, and by default it enables Rocket WS which I don't find an option disable.
setting
WEBSOCKET_ENABLED
to false doesn't work as it stated in https://github.com/dani-garcia/vaultwarden/wiki/Enabling-WebSocket-notificationsExpected behaviour
Having a new option to forcibly disable the websocket feature.
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden:
The text was updated successfully, but these errors were encountered: