Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change timestamp data type. #4355

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

gzfrozen
Copy link
Contributor

@gzfrozen gzfrozen commented Feb 15, 2024

Fix the "Year 2038 problem".

  • Change the data type of last_used in twofactor table.
  • Create migration files.
  • Delete unnessary type convertion.
  • Tested in SQlite, MySQL, Postgres.
    • Test method: add the two step authenticator to a account using the original code, then update the code to see if it can still login

I am not confident if it is the only "Year 2038 problem". If there are still other problems please let me know.

Fixes #4177

@gzfrozen gzfrozen mentioned this pull request Feb 15, 2024
BlackDex
BlackDex previously approved these changes Feb 16, 2024
Copy link
Owner

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Had to resolve a small merge conflict but LGTM!

@dani-garcia dani-garcia merged commit 000c606 into dani-garcia:main Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Year 2038 problem
3 participants