Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome extension fails CORS due to missing origin #4665

Closed
RaidAndFade opened this issue Jun 22, 2024 · 2 comments
Closed

Chrome extension fails CORS due to missing origin #4665

RaidAndFade opened this issue Jun 22, 2024 · 2 comments

Comments

@RaidAndFade
Copy link

Subject of the issue

Latest version of chrome bitwarden extension requires cors header response, which current codebase does not do.

Steps to reproduce

Download bitwarden chrome extension, try to use vaultwarden as a backend, all POST requests fail due to missing ORIGIN header

Expected behaviour

expect bitwarden extension works

Actual behaviour

bitwarden extension receives data but cannot push any new information to vault

Troubleshooting data

origin header is of format
Origin: chrome-extension://nngceckbfpebfimklniiiawkandclblb
Code found at https://github.com/dani-garcia/vaultwarden/blame/main/src/util.rs#L133 to allow the domain as well as safari extension "file://" but not chrome-extension prefix. Believe some work is doable there.

@RaidAndFade
Copy link
Author

Actually, looks to be an issue on the extension itself, there is a closed ticket there that explains the problem, this workaround seems to resolve the issue
bitwarden/clients#1612 (comment)

@BlackDex
Copy link
Collaborator

BlackDex commented Jul 8, 2024

Closing this as it's a client issue, which also seems to be fixed already.

@BlackDex BlackDex closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants