New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme edits #10
Merged
Merged
Readme edits #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add step 02 link.
Add link for step 02
Add link step 03
Add link step 04
Add link step 05
Add link step 05
Add link to step 05
Add link step 05
Add link step 06
Add link step 07
Add link step 08
Add link step 05
Add link optional step
Add link optional step
Add link to main home repository.
danicat
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Oh, I've just noticed you used the path to your fork instead. Will have to revert this, sorry! |
Merged
danicat
added a commit
that referenced
this pull request
Oct 10, 2019
Lol, this one i dont know how. Still new to this PR, git thingy. TEach me
the ropes please :-))
--
Best Regards,
Eriberto Mendez
[image: Google Plus] <http://plus.google.com/u/0/100658196947137714991> [image:
Twitter] <http://www.twitter.com/bertmendz> [image: LinkedIn]
<http://sa.linkedin.com/in/eribertomendez>
Get a signature like this.
<http://r1.wisestamp.com/r/landing?promo=18&dest=http%3A%2F%2Fwww.wisestamp.com%2Femail-install%3Futm_source%3Dextension%26utm_medium%3Demail%26utm_campaign%3Dpromo_18>Click
here.
<http://r1.wisestamp.com/r/landing?promo=18&dest=http%3A%2F%2Fwww.wisestamp.com%2Femail-install%3Futm_source%3Dextension%26utm_medium%3Demail%26utm_campaign%3Dpromo_18>
…On Thu, Oct 10, 2019 at 12:55 PM Daniela Petruzalek < ***@***.***> wrote:
Oh, I've just noticed you used the path to your fork instead. Will have to
revert this, sorry!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10?email_source=notifications&email_token=AM5G2JLVZ4GSTT6SHMKD4BDQN33XXA5CNFSM4I3AZ762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA3USEY#issuecomment-540494099>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM5G2JN4EGOCTUI6Q32LM3LQN33XXANCNFSM4I3AZ76Q>
.
|
Instead of using absolute paths, you should have used relative paths. I've just merged another PR that proposed the same thing, but with relative paths. Have a look at #11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add links at end of each step exercise :-)