Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme edits #10

Merged
merged 16 commits into from Oct 10, 2019
Merged

Readme edits #10

merged 16 commits into from Oct 10, 2019

Conversation

eribertto
Copy link
Contributor

Add links at end of each step exercise :-)

Add step 02 link.
Add link for step 02
Add link step 03
Add link step 04
Add link step 05
Add link step 05
Add link to step 05
Add link step 05
Add link step 06
Add link step 07
Add link step 08
Add link step 05
Add link optional step
Add link optional step
Add link to main home repository.
Copy link
Owner

@danicat danicat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danicat danicat merged commit b10ee42 into danicat:master Oct 10, 2019
@danicat
Copy link
Owner

danicat commented Oct 10, 2019

Oh, I've just noticed you used the path to your fork instead. Will have to revert this, sorry!

danicat added a commit that referenced this pull request Oct 10, 2019
This reverts commit b10ee42.
@danicat danicat mentioned this pull request Oct 10, 2019
danicat added a commit that referenced this pull request Oct 10, 2019
@eribertto
Copy link
Contributor Author

eribertto commented Oct 10, 2019 via email

@danicat
Copy link
Owner

danicat commented Oct 10, 2019

Instead of using absolute paths, you should have used relative paths. I've just merged another PR that proposed the same thing, but with relative paths. Have a look at #11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants