Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractDiscipline deploy failing #10

Closed
jbussemaker opened this issue Jul 5, 2018 · 4 comments
Closed

AbstractDiscipline deploy failing #10

jbussemaker opened this issue Jul 5, 2018 · 4 comments

Comments

@jbussemaker
Copy link

Tested with Anaconda Python 3.6.

When running the Sellar test problem, the AbstractDiscipline deploy function is failing because the XML files are opened in w-mode while the etree.tostring methods as used by the Sellar problem disciplines are returning byte arrays.

The reason for this is a well-known Python bug (or can we call it a feature?):
https://bugs.python.org/issue10942
https://docs.python.org/3/library/xml.etree.elementtree.html#xml.etree.ElementTree.tostring

Suggest to resolve it by writing a new XML-utils function that makes sure that the output of etree.tostring always is of string type.

@daniel-de-vries
Copy link
Owner

Does this issue also occur with Python 2.7?

@jbussemaker
Copy link
Author

No it does not

@daniel-de-vries
Copy link
Owner

Since OpenLEGO depends on kadmos, which targets only Python 2.7, I think the best way to move forward is to change OpenLEGO's target to only support Python 2.7 as well. This would resolve this issue.

@daniel-de-vries
Copy link
Owner

Target Python 3.6 removed from setup.py. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants