Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that fail because validation error message changes in laravel/laravel 8.5.21 #63

Conversation

dennis-koster
Copy link

@dennis-koster dennis-koster commented Aug 4, 2021

When checking out this package and running the tests, some assertions on URL validity error messages fail, if the installed version of orchestra/testbench-core is equal or higher than ^v6.23.1, because of this change:
orchestral/testbench-core@f189915

Or the laravel/laravel equivalent:
laravel/laravel@8665891

To fix this, I have added a more explicit requirement for orchestra/testbench-core in the composer.json file. This is, unfortunately, a breaking change.

@wimski
Copy link
Collaborator

wimski commented Aug 4, 2021

@daniel-de-wit do you have an issue with this?

@dennis-koster 8.5.21 is sufficient
https://github.com/laravel/laravel/releases/tag/v8.5.21

@dennis-koster dennis-koster force-pushed the bugfix/fix-failing-tests-because-of-changes-validation-error-messages branch from 3ed4e81 to 932ed6a Compare August 4, 2021 14:39
@dennis-koster dennis-koster changed the title Fix tests that fail because validation error message changes in laravel/laravel 8.5.23 Fix tests that fail because validation error message changes in laravel/laravel 8.5.21 Aug 4, 2021
@coveralls
Copy link

coveralls commented Aug 4, 2021

Pull Request Test Coverage Report for Build 1098041157

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.611%

Totals Coverage Status
Change from base Build 1025809167: 0.0%
Covered Lines: 256
Relevant Lines: 257

💛 - Coveralls

@dennis-koster dennis-koster force-pushed the bugfix/fix-failing-tests-because-of-changes-validation-error-messages branch from a6d22d7 to 8f10f6c Compare August 4, 2021 17:53
@daniel-de-wit daniel-de-wit merged commit 7ed4b36 into daniel-de-wit:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants