Add AndroidX support

[systemallica]

The release of the new AndroidX packages is imminent, and this library cannot be used with AndroidX in its current state.

Given that all new development will be done in the AndroidX packages, I think that supporting it would be a good idea.

A refactoring guide can be found here. I don't know if further modifications would be necessary.

[daniel-stoneuk]

Good point. I'll update the support library versions and add AndroidX support.

[daniel-stoneuk]

Do you know if it works yet with jetifier?

[systemallica]

Actually I'm not sure. I'm still using Android Studio 3.1.4

[eclectice]

jetifier

The latest AndroidX should be OK

gradle.properties

android.useAndroidX = true
android.enableJetifier = false

build gradle

implementation "com.google.android.material:material:$material_version"
implementation "androidx.appcompat:appcompat:$legacy_support_version"    
implementation "androidx.legacy:legacy-support-v4:$legacy_support_version"
implementation "androidx.legacy:legacy-support-v13:$legacy_support_version"

I really like to use your About library since there is a support for Licenses entry. But, I have just moved to AndroidX.

[eclectice]

OK, I try to refactor everything in your library codes to AndroidX but the example app uses LicenseAdapter from GITHUB yshrsmz/LicenseAdapter which currently doesn't support AndroidX.

{update redacted into a new post reply}

[daniel-stoneuk]

Thanks for taking a look into it. The example using License adapter as an example actually isn't in the latest release, I'm wondering if supporting custom adapters is a good feature.

So you can confirm jetifier does not work with material about library? If this is the case, I'll probably create a new branch and support both support library and AndroidX versions separately.

On another note, how many libraries have you encountered that don't play well with AndroidX, I'm looking to migrate soon.

[eclectice]

Thanks for taking a look into it. The example using License adapter as an example actually isn't in the latest release, I'm wondering if supporting custom adapters is a good feature.

So you can confirm jetifier does not work with material about library? If this is the case, I'll probably create a new branch and support both support library and AndroidX versions separately.

On another note, how many libraries have you encountered that don't play well with AndroidX, I'm looking to migrate soon.

I have tried set android.enableJetifier = true and it seems okay. But, I only change that part. So, obviously, I haven't done anything.

About custom adapter support, I think it is a choice and it looks fine to me.

On the other hand, the developer of LicenseAdapter seems inclined to support it yshrsmz/LicenseAdapter#53

[daniel-stoneuk]

Thanks. I would also like to add AndroidX support, however, I am more inclined to wait until AndroidX is more common because (correct me if I'm wrong) whilst a support library dep can be used with jetifier, an AndroidX dep can't be used in a support library project.

Would you agree here or do you think I should create two separate branches?

[eclectice]

Yes, I guess having two separate branches (Support Lib and AndroidX) is the best solution at the moment until AndroidX becomes common...

…

On Mon, Sep 17, 2018 at 11:56 PM Daniel Stone ***@***.***> wrote: Thanks. I would also like to add AndroidX support, however, I am more inclined to wait until AndroidX is more common because (correct me if I'm wrong) whilst a support library dep can be used with jetifier, an AndroidX dep can't be used in a support library project. Would you agree here or do you think I should create two separate branches? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#87 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYqcCl-SCx3dYYGfU83zxf5K2TUnivQks5ub8ZAgaJpZM4WB-gR> .

[bernaferrari]

Released now! Keep in mind all future updates to support library will only happen in androidx.

[leosarra]

I tried using AndroidX (with jetifier on) but the MaterialAboutActivity doesn't provide any getResources() or startActivity(). getString etc
It was fine before I did the refactoring

[DerTyp7214]

i compiled by myself without testapp.
if someone need it with androidx: https://github.com/DerTyp7214/material-about-library/releases/tag/2.3.0

[eclectice]

I tried implementation "com.github.daniel-stoneuk:material-about-library:2.3.0" but I think the MaterialAboutCard.Builder.customAdapter is broken.

Update: OK, I understand 2.3.0 tag is the old one. I should use the one from DerTyp7214

[daniel-stoneuk]

Hi guys, apologies for the delay.

Could you please test if 2.4.2 works?

Thanks

[DerTyp7214]

@daniel-stoneuk I will try when I'm back from work

[eclectice]

Tested this about-library release 2.4.2 (Androidx) with the customAdapter support for my app. It works fine now with the LicenseAdapter version 2.2.2.

…

On Thu, Oct 25, 2018 at 2:28 PM Josua Lengwenath ***@***.***> wrote: @daniel-stoneuk <https://github.com/daniel-stoneuk> I will try when I'm back from work — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#87 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYqcBHx9T4TOPik91DJA2IUK3Oq1KUrks5uoVoigaJpZM4WB-gR> .

[daniel-stoneuk]

Brilliant! Hopefully support for @yshrsmz 's LicenseAdapter should make life a bit easier! @eclectice

[systemallica]

The new version is working great, thank you.